New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#285: Add internet().uuidv3() #286

Merged

bodiam merged 1 commit into datafaker-net:master from unknown repository

Aug 9, 2022

ghost commented Aug 9, 2022

First PR to this project, feel free to provide feedback on what to change.

Added:

internet().uuidv3()
nextRandomBytes()
Two tests: one whether the format is correct and one to test whether constant random seeds do what they're supposed to (which is the entire reason for this PR)

Notes:

Using 16 bytes for generating UUID since it covers the entire UUID
maven site didn't work locally, I hope the provided javadocs are okay
It's also unclear how versioning works, should I increase the minor version?
Should I add something to the changelog?


          Add internet().uuidv3()

60ea14f

Contributor

bodiam commented Aug 9, 2022

This PR looks good to me! Small note on the Javadoc, but nothing big. Thanks for your contribution!

bodiam merged commit 2862ad3 into datafaker-net:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet