Skip to content

#285: Add internet().uuidv3()#286

Merged
bodiam merged 1 commit into
masterfrom
unknown repository
Aug 9, 2022
Merged

#285: Add internet().uuidv3()#286
bodiam merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Aug 9, 2022

Copy link
Copy Markdown

First PR to this project, feel free to provide feedback on what to change.

Added:

  • internet().uuidv3()
  • nextRandomBytes()
  • Two tests: one whether the format is correct and one to test whether constant random seeds do what they're supposed to (which is the entire reason for this PR)

Notes:

  • Using 16 bytes for generating UUID since it covers the entire UUID
  • maven site didn't work locally, I hope the provided javadocs are okay
  • It's also unclear how versioning works, should I increase the minor version?
  • Should I add something to the changelog?

@bodiam

bodiam commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

This PR looks good to me! Small note on the Javadoc, but nothing big. Thanks for your contribution!

@bodiam bodiam merged commit 2862ad3 into datafaker-net:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant