Skip to content

Feature/garments sizes#289

Merged
bodiam merged 9 commits into
datafaker-net:masterfrom
p4pupro:feature/garments_sizes
Aug 11, 2022
Merged

Feature/garments sizes#289
bodiam merged 9 commits into
datafaker-net:masterfrom
p4pupro:feature/garments_sizes

Conversation

@p4pupro

@p4pupro p4pupro commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

name: Add Garments Sizes Faker
about: new feature to use Garments Sizes. see example: XS, S, M, L, XL, XXL, XXXL
title: 'Garments Sizes'
labels: 'Garments Sizes'
assignees: ''


Is your feature request related to a problem? Please describe.
No, is just a feature.

Describe the solution you'd like
None.

Describe alternatives you've considered
None.

Additional context
None.

Comment thread src/main/java/net/datafaker/GarmentSize.java Outdated
Comment thread src/main/resources/en/garments_sizes.yml Outdated
@bodiam

bodiam commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

Hi @p4pupro , thanks for the PR! I've left a few comments, could you have a look? Also, it seems the build is failing, I'm not sure if that's caused by this PR, but could you please have a look at it? Thanks!

Comment thread src/main/java/net/datafaker/Faker.java Outdated
@codecov-commenter

codecov-commenter commented Aug 11, 2022

Copy link
Copy Markdown

Codecov Report

Merging #289 (e03ffa7) into master (6de8418) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master     #289      +/-   ##
============================================
- Coverage     94.84%   94.80%   -0.05%     
- Complexity     1881     1887       +6     
============================================
  Files           194      196       +2     
  Lines          3781     3790       +9     
  Branches        379      379              
============================================
+ Hits           3586     3593       +7     
- Misses           99      100       +1     
- Partials         96       97       +1     
Impacted Files Coverage Δ
.../main/java/net/datafaker/service/files/EnFile.java 93.33% <ø> (ø)
src/main/java/net/datafaker/Faker.java 98.34% <100.00%> (+0.01%) ⬆️
src/main/java/net/datafaker/GarmentSize.java 100.00% <100.00%> (ø)
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 92.59% <0.00%> (-3.71%) ⬇️
src/main/java/net/datafaker/Community.java 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam

bodiam commented Aug 11, 2022

Copy link
Copy Markdown
Contributor

Looks good to me. Thanks for the quick fixes!

@bodiam bodiam merged commit c2c2da8 into datafaker-net:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants