Feature/garments sizes#289
Merged
Merged
Conversation
bodiam
reviewed
Aug 11, 2022
bodiam
reviewed
Aug 11, 2022
Contributor
|
Hi @p4pupro , thanks for the PR! I've left a few comments, could you have a look? Also, it seems the build is failing, I'm not sure if that's caused by this PR, but could you please have a look at it? Thanks! |
panilya
reviewed
Aug 11, 2022
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
============================================
- Coverage 94.84% 94.80% -0.05%
- Complexity 1881 1887 +6
============================================
Files 194 196 +2
Lines 3781 3790 +9
Branches 379 379
============================================
+ Hits 3586 3593 +7
- Misses 99 100 +1
- Partials 96 97 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Looks good to me. Thanks for the quick fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Add Garments Sizes Faker
about: new feature to use Garments Sizes. see example: XS, S, M, L, XL, XXL, XXXL
title: 'Garments Sizes'
labels: 'Garments Sizes'
assignees: ''
Is your feature request related to a problem? Please describe.
No, is just a feature.
Describe the solution you'd like
None.
Describe alternatives you've considered
None.
Additional context
None.