-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/garments sizes #289
Conversation
Hi @p4pupro , thanks for the PR! I've left a few comments, could you have a look? Also, it seems the build is failing, I'm not sure if that's caused by this PR, but could you please have a look at it? Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
============================================
- Coverage 94.84% 94.80% -0.05%
- Complexity 1881 1887 +6
============================================
Files 194 196 +2
Lines 3781 3790 +9
Branches 379 379
============================================
+ Hits 3586 3593 +7
- Misses 99 100 +1
- Partials 96 97 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Looks good to me. Thanks for the quick fixes! |
name: Add Garments Sizes Faker
about: new feature to use Garments Sizes. see example: XS, S, M, L, XL, XXL, XXXL
title: 'Garments Sizes'
labels: 'Garments Sizes'
assignees: ''
Is your feature request related to a problem? Please describe.
No, is just a feature.
Describe the solution you'd like
None.
Describe alternatives you've considered
None.
Additional context
None.