Change error count threshold value in PhoneNumberValidityFinderTest.testAllPhoneNumber #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estAllPhoneNumbers
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
============================================
+ Coverage 94.80% 94.85% +0.05%
- Complexity 1886 1888 +2
============================================
Files 196 196
Lines 3790 3790
Branches 379 379
============================================
+ Hits 3593 3595 +2
+ Misses 100 99 -1
+ Partials 97 96 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
That's fine too 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to propose lower error count in the test, all the locales (except for 2, they are not actually phone numbers locale, I will raise an issue later on this) are now under 50 error count threshold, so I think it would be better to lower error count in order to be able to detect some incorrect phone number formats, and improve them more.