Add "Mass Effect" faker #301
Conversation
README.md
Outdated
| * Witcher | ||
| * Yoda | ||
| * Zelda | ||
| * Mass Effect |
There was a problem hiding this comment.
Would be better to follow abc ordering
| return getProvider(Zelda.class, () -> new Zelda(this)); | ||
| } | ||
|
|
||
| public MassEffect massEffect() { |
There was a problem hiding this comment.
Please follow abc ordering in providers methods
it would simplify code navigation
| "yoda.yml", | ||
| "zelda.yml").map(EnFile::new).collect(Collectors.toList()); | ||
| "zelda.yml", | ||
| "mass-effect.yml").map(EnFile::new).collect(Collectors.toList()); |
| testAllMethodsThatReturnStringsActuallyReturnStrings(faker.yoda()); | ||
| testAllMethodsThatReturnStringsActuallyReturnStrings(faker.zelda()); | ||
| testAllMethodsThatReturnStringsActuallyReturnStrings(faker.oscarMovie()); | ||
| testAllMethodsThatReturnStringsActuallyReturnStrings(faker.massEffect()); |
There was a problem hiding this comment.
Please, follow order here too
There was a problem hiding this comment.
have also moved oscarMovie to the right place.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
============================================
+ Coverage 94.86% 94.87% +0.01%
- Complexity 1893 1900 +7
============================================
Files 197 198 +1
Lines 3797 3805 +8
Branches 379 379
============================================
+ Hits 3602 3610 +8
Misses 99 99
Partials 96 96 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Awesome, thank you for this! |
5 participants
Add Mass Effect Faker with character/specie/planet/cluster -names and quotes.