Add "Mass Effect" faker #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snuyanzin
reviewed
Aug 16, 2022
README.md
Outdated
| @@ -309,6 +309,7 @@ Providers | |||
| * Witcher | |||
| * Yoda | |||
| * Zelda | |||
| * Mass Effect | |||
There was a problem hiding this comment.
Would be better to follow abc ordering
snuyanzin
reviewed
Aug 16, 2022
| @@ -1019,6 +1019,10 @@ public Zelda zelda() { | |||
| return getProvider(Zelda.class, () -> new Zelda(this)); | |||
| } | |||
|
|
|||
| public MassEffect massEffect() { | |||
There was a problem hiding this comment.
Please follow abc ordering in providers methods
it would simplify code navigation
snuyanzin
reviewed
Aug 16, 2022
| @@ -224,7 +224,8 @@ public String getPath() { | |||
| // "world_cup.yml", | |||
| // "world_of_warcraft.yml", | |||
| "yoda.yml", | |||
| "zelda.yml").map(EnFile::new).collect(Collectors.toList()); | |||
| "zelda.yml", | |||
| "mass-effect.yml").map(EnFile::new).collect(Collectors.toList()); | |||
panilya
reviewed
Aug 17, 2022
| @@ -205,6 +205,7 @@ void testAllFakerMethodsThatReturnStrings(Locale locale, Random random) throws E | |||
| testAllMethodsThatReturnStringsActuallyReturnStrings(faker.yoda()); | |||
| testAllMethodsThatReturnStringsActuallyReturnStrings(faker.zelda()); | |||
| testAllMethodsThatReturnStringsActuallyReturnStrings(faker.oscarMovie()); | |||
| testAllMethodsThatReturnStringsActuallyReturnStrings(faker.massEffect()); | |||
There was a problem hiding this comment.
Please, follow order here too
There was a problem hiding this comment.
have also moved oscarMovie to the right place.
Codecov Report
@@ Coverage Diff @@
## master #301 +/- ##
============================================
+ Coverage 94.86% 94.87% +0.01%
- Complexity 1893 1900 +7
============================================
Files 197 198 +1
Lines 3797 3805 +8
Branches 379 379
============================================
+ Hits 3602 3610 +8
Misses 99 99
Partials 96 96
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Awesome, thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Mass Effect Faker with character/specie/planet/cluster -names and quotes.