Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back StarWars #314

Merged
merged 12 commits into from
Aug 24, 2022
Merged

Bring back StarWars #314

merged 12 commits into from
Aug 24, 2022

Conversation

redhell
Copy link
Contributor

@redhell redhell commented Aug 23, 2022

I don't know why the Star Wars Provider was removed but here it is back in action.

@redhell redhell closed this Aug 24, 2022
@redhell redhell reopened this Aug 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2022

Codecov Report

Merging #314 (d2ca222) into master (b2544de) will decrease coverage by 0.27%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #314      +/-   ##
============================================
- Coverage     94.89%   94.61%   -0.28%     
- Complexity     1916     1928      +12     
============================================
  Files           201      203       +2     
  Lines          3823     3866      +43     
  Branches        379      383       +4     
============================================
+ Hits           3628     3658      +30     
- Misses           99      112      +13     
  Partials         96       96              
Impacted Files Coverage Δ
src/main/java/net/datafaker/Faker.java 97.98% <0.00%> (-0.40%) ⬇️
src/main/java/net/datafaker/StarWars.java 0.00% <0.00%> (ø)
src/main/java/net/datafaker/Unique.java 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam
Copy link
Contributor

bodiam commented Aug 24, 2022

Hi @redhell , thanks for bringing it back, I also have no idea why it was gone, but could you please add a test for this?

@redhell
Copy link
Contributor Author

redhell commented Aug 24, 2022

yep, I'm on it.

I'll commit them when finished. Please squash the commits after.

@redhell
Copy link
Contributor Author

redhell commented Aug 24, 2022

@bodiam Test ✅

Please squash commits and merge :)

@bodiam bodiam merged commit d95f572 into datafaker-net:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants