Bring back StarWars#314
Merged
Merged
Conversation
I don't know why this is missing
Added StarWars
added 2 commits
August 24, 2022 09:05
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
============================================
- Coverage 94.89% 94.61% -0.28%
- Complexity 1916 1928 +12
============================================
Files 201 203 +2
Lines 3823 3866 +43
Branches 379 383 +4
============================================
+ Hits 3628 3658 +30
- Misses 99 112 +13
Partials 96 96
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Hi @redhell , thanks for bringing it back, I also have no idea why it was gone, but could you please add a test for this? |
Contributor
Author
|
yep, I'm on it. I'll commit them when finished. Please squash the commits after. |
added 4 commits
August 24, 2022 20:12
Contributor
Author
|
@bodiam Test ✅ Please squash commits and merge :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know why the Star Wars Provider was removed but here it is back in action.