Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown documentation for unique faker #321

Merged
merged 4 commits into from
Sep 1, 2022

Conversation

giunto
Copy link
Contributor

@giunto giunto commented Sep 1, 2022

This PR will add documentation for the unique faker in the main README.md as well as a separate markdown file detailing its usage. Let me know if everything written sounds okay.

@epragtbeamtree
Copy link

@snuyanzin Seems we still have concurrency issues.

@epragtbeamtree
Copy link

Great work @giunto , thanks. Would it be possible to add this page also to the mkdocs.yml file, so it's part of the index/navigation?

@bodiam bodiam merged commit dc4c7b4 into datafaker-net:master Sep 1, 2022
@giunto
Copy link
Contributor Author

giunto commented Sep 1, 2022

Added. Thanks for letting me know.

@bodiam
Copy link
Contributor

bodiam commented Sep 1, 2022

Thanks!

Added. Thanks for letting me know.

No worries at all. Thanks for providing the documentation, it's live now: https://www.datafaker.net/documentation/unique-values/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants