Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support japan passport number #328

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Support japan passport number #328

merged 1 commit into from
Sep 9, 2022

Conversation

yuokada
Copy link
Contributor

@yuokada yuokada commented Sep 9, 2022 •
edited
Loading

issue: #268

@yuokada yuokada marked this pull request as ready for review September 9, 2022 06:29
@yuokada
Copy link
Contributor Author

yuokada commented Sep 9, 2022

@snuyanzin or @bodiam Could you please take a look if you have a chance?

@bodiam
Copy link
Contributor

bodiam commented Sep 9, 2022

@yuokada Thanks for the PR, looks fine to me! It will be available in the 1.6.0-SNAPSHOT in a few minutes.

@bodiam bodiam merged commit 0e326aa into datafaker-net:master Sep 9, 2022
@yuokada yuokada deleted the ja-JP_passport-number branch September 9, 2022 07:17
@yuokada
Copy link
Contributor Author

yuokada commented Sep 9, 2022

@bodiam Thanks for reviewing and merging my PR. 😄

@epragtbeamtree
Copy link

@yuokada My pleasure, you contribution is welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuokada @bodiam @epragtbeamtree