Skip to content

Refactor barcode#344

Merged
snuyanzin merged 1 commit intodatafaker-net:mainfrom
snuyanzin:barcode
Sep 12, 2022
Merged

Refactor barcode#344
snuyanzin merged 1 commit intodatafaker-net:mainfrom
snuyanzin:barcode

Conversation

@snuyanzin
Copy link
Collaborator

The PR simplify ean generation + optimizes it by removal of useless toString and toLong transformations

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2022

Codecov Report

Merging #344 (5865517) into main (65a5152) will decrease coverage by 0.07%.
The diff coverage is 86.95%.

@@             Coverage Diff              @@
##               main     #344      +/-   ##
============================================
- Coverage     94.93%   94.85%   -0.08%     
+ Complexity     1938     1935       -3     
============================================
  Files           203      203              
  Lines          3866     3869       +3     
  Branches        383      385       +2     
============================================
  Hits           3670     3670              
- Misses          100      101       +1     
- Partials         96       98       +2     
Impacted Files Coverage Δ
src/main/java/net/datafaker/Barcode.java 90.47% <86.95%> (-6.96%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit 46cc941 into datafaker-net:main Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants