Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing state (Flevoland) for Netherlands. #352

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

jaapcoomans
Copy link
Contributor

The address faker for the Netherlands (nl) lists only 11 out of 12 provinces as a state. This PR adds the only one that was still missing: Flevoland.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2022

Codecov Report

Merging #352 (2637c41) into main (6f82121) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #352   +/-   ##
=========================================
  Coverage     94.85%   94.85%           
- Complexity     1934     1935    +1     
=========================================
  Files           203      203           
  Lines          3869     3869           
  Branches        385      385           
=========================================
  Hits           3670     3670           
  Misses          101      101           
  Partials         98       98           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam
Copy link
Contributor

bodiam commented Sep 13, 2022

Oops, that's a shameful omission, that's my birth province! Thanks for adding it!

@bodiam bodiam merged commit 82aeac8 into datafaker-net:main Sep 13, 2022
@jaapcoomans jaapcoomans deleted the nl-add-missing-province branch September 15, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants