Add new JSON generation example in file formats docs#354
Merged
panilya merged 2 commits intodatafaker-net:mainfrom Sep 13, 2022
Merged
Add new JSON generation example in file formats docs#354panilya merged 2 commits intodatafaker-net:mainfrom
panilya merged 2 commits intodatafaker-net:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #354 +/- ##
============================================
- Coverage 94.85% 94.80% -0.06%
+ Complexity 1935 1934 -1
============================================
Files 203 203
Lines 3869 3869
Branches 385 385
============================================
- Hits 3670 3668 -2
- Misses 101 102 +1
- Partials 98 99 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
|
Since it is example of simple JSON generation I think it would make sense to place it at the very beginning of JSON section and then more complex examples |
snuyanzin
approved these changes
Sep 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #346