Skip to content

Add new JSON generation example in file formats docs #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2022

Conversation

panilya
Copy link
Collaborator

@panilya panilya commented Sep 13, 2022

Issue: #346

@panilya panilya requested a review from snuyanzin September 13, 2022 19:57
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2022

Codecov Report

Merging #354 (2ef2ed2) into main (03ceb70) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #354      +/-   ##
============================================
- Coverage     94.85%   94.80%   -0.06%     
+ Complexity     1935     1934       -1     
============================================
  Files           203      203              
  Lines          3869     3869              
  Branches        385      385              
============================================
- Hits           3670     3668       -2     
- Misses          101      102       +1     
- Partials         98       99       +1     
Impacted Files Coverage Δ
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 92.59% <0.00%> (-3.71%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin
Copy link
Collaborator

Since it is example of simple JSON generation I think it would make sense to place it at the very beginning of JSON section and then more complex examples

@panilya panilya merged commit ed2b818 into datafaker-net:main Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants