Skip to content

Fix flaky test #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Fix flaky test #358

merged 1 commit into from
Sep 15, 2022

Conversation

jaapcoomans
Copy link
Contributor

Fixes flaky test introduced in #355.

The pattern expects a single word, while one of the possible values consists of 2 words. Used a different pattern for the test.

@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2022

Codecov Report

Merging #358 (8c5f7a4) into main (01cb68b) will increase coverage by 0.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #358      +/-   ##
============================================
+ Coverage     94.62%   94.86%   +0.23%     
- Complexity     1934     1938       +4     
============================================
  Files           203      203              
  Lines          3867     3872       +5     
  Branches        385      385              
============================================
+ Hits           3659     3673      +14     
+ Misses          112      101      -11     
- Partials         96       98       +2     
Impacted Files Coverage Δ
src/main/java/net/datafaker/Internet.java 90.47% <0.00%> (-0.44%) ⬇️
.../java/net/datafaker/service/FakeValuesService.java 87.92% <0.00%> (+0.42%) ⬆️
src/main/java/net/datafaker/Code.java 97.70% <0.00%> (+2.29%) ⬆️
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 96.29% <0.00%> (+3.70%) ⬆️
...ain/java/net/datafaker/idnumbers/EnZAIdNumber.java 91.66% <0.00%> (+8.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam bodiam merged commit 59e77b8 into datafaker-net:main Sep 15, 2022
@bodiam
Copy link
Contributor

bodiam commented Sep 15, 2022

Funny that this fix showed a new flaky test... Thanks for fixing!

@jaapcoomans
Copy link
Contributor Author

@bodiam That's inception indeed 😁
Reported an issue instead of directly fixing the other flaky test because I'm unsure about what to fix: the test of the implementation.

@bodiam
Copy link
Contributor

bodiam commented Sep 15, 2022

Thanks for reporting it, I do appreciate that. I'll have a look later to see what the best approach is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants