Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all provider registration to a separate interface #365

Merged
merged 1 commit into from
Sep 17, 2022

Conversation

snuyanzin
Copy link
Collaborator

The PR moves all provider registration methods to a separate interface IProviders (i'm not good with naming).
The idea here is that in future this interfaces could be splitted into separate module specific interfaces and all generic Faker will stay with Faker class

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2022

Codecov Report

Merging #365 (387a211) into main (b410621) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #365   +/-   ##
=========================================
  Coverage     94.75%   94.75%           
- Complexity     1945     1947    +2     
=========================================
  Files           204      205    +1     
  Lines          3887     3889    +2     
  Branches        385      385           
=========================================
+ Hits           3683     3685    +2     
  Misses          103      103           
  Partials        101      101           
Impacted Files Coverage Δ
src/main/java/net/datafaker/Address.java 97.14% <ø> (ø)
src/main/java/net/datafaker/Faker.java 93.75% <100.00%> (-4.29%) ⬇️
src/main/java/net/datafaker/IProviders.java 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit 387a211 into datafaker-net:main Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants