Move all provider registration to a separate interface#365
Merged
snuyanzin merged 1 commit intodatafaker-net:mainfrom Sep 17, 2022
Merged
Move all provider registration to a separate interface#365snuyanzin merged 1 commit intodatafaker-net:mainfrom
snuyanzin merged 1 commit intodatafaker-net:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #365 +/- ##
=========================================
Coverage 94.75% 94.75%
- Complexity 1945 1947 +2
=========================================
Files 204 205 +1
Lines 3887 3889 +2
Branches 385 385
=========================================
+ Hits 3683 3685 +2
Misses 103 103
Partials 101 101
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
a14d38a to
bda9aeb
Compare
bda9aeb to
387a211
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR moves all provider registration methods to a separate interface
IProviders(i'm not good with naming).The idea here is that in future this interfaces could be splitted into separate module specific interfaces and all generic
Fakerwill stay withFakerclass