Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put open mocks in try catch #366

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Put open mocks in try catch #366

merged 1 commit into from
Sep 17, 2022

Conversation

snuyanzin
Copy link
Collaborator

The PR makes open mocks in autoclosable, removes usage of deprecated Faker#instance and fix some warnings about assertJ methods

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2022

Codecov Report

Merging #366 (d7a2168) into main (2c1a3f3) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #366      +/-   ##
============================================
- Coverage     94.67%   94.65%   -0.03%     
+ Complexity     1945     1943       -2     
============================================
  Files           205      205              
  Lines          3889     3888       -1     
  Branches        385      385              
============================================
- Hits           3682     3680       -2     
+ Misses          108      107       -1     
- Partials         99      101       +2     
Impacted Files Coverage Δ
.../java/net/datafaker/service/FakeValuesService.java 87.31% <100.00%> (-0.03%) ⬇️
src/main/java/net/datafaker/Faker.java 88.75% <0.00%> (-5.00%) ⬇️
.../main/java/net/datafaker/service/FakerContext.java 86.84% <0.00%> (+2.63%) ⬆️
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 96.29% <0.00%> (+3.70%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit d7a2168 into datafaker-net:main Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants