Introduce SportFaker and move all sport related fakers under it#369
Merged
snuyanzin merged 1 commit intodatafaker-net:mainfrom Sep 19, 2022
Merged
Introduce SportFaker and move all sport related fakers under it#369snuyanzin merged 1 commit intodatafaker-net:mainfrom
snuyanzin merged 1 commit intodatafaker-net:mainfrom
Conversation
Introduce BaseFaker and Make Faker as a combination of SportFaker and BaseFaker
Codecov Report
@@ Coverage Diff @@
## main #369 +/- ##
============================================
- Coverage 94.65% 94.58% -0.07%
- Complexity 1943 1947 +4
============================================
Files 205 209 +4
Lines 3888 3899 +11
Branches 385 385
============================================
+ Hits 3680 3688 +8
- Misses 107 111 +4
+ Partials 101 100 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce BaseFaker and make Faker as a combination of SportFaker and BaseFaker.
In case there is a wish to have object without sport providers then BaseFaker could be used.
Extractions of other specific faker could be done in similar way