Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more European makes and models for the Vehicle provider #380

Merged

Conversation

jaapcoomans
Copy link
Contributor

The current lists of vehicle makes and models did not include many cars that are common in Europe. As discussed in #350.
Extended the lists in vehicle.yml based on some resources on best selling cars in Europe of the past few years.

Changed test assertion to accept Citroën and Mercedes-Benz as valid values.

@bodiam
Copy link
Contributor

bodiam commented Sep 23, 2022

Awesome! Thanks. Seems the test doesn't like VW Id.4 though

@jaapcoomans
Copy link
Contributor Author

Indeed, I missed some test patterns. Fixed it 👨‍🔧

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022

Codecov Report

Merging #380 (9868b45) into main (71b511d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #380   +/-   ##
=========================================
  Coverage     93.68%   93.68%           
  Complexity     1951     1951           
=========================================
  Files           215      215           
  Lines          3942     3942           
  Branches        385      385           
=========================================
  Hits           3693     3693           
  Misses          149      149           
  Partials        100      100           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit e20dec6 into datafaker-net:main Sep 23, 2022
@bodiam
Copy link
Contributor

bodiam commented Sep 23, 2022

Thanks Jaap for this pr! Btw, seems our random testing isn't so bad ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants