Add more European makes and models for the Vehicle provider#380
Merged
snuyanzin merged 2 commits intoSep 23, 2022
Merged
Conversation
Contributor
|
Awesome! Thanks. Seems the test doesn't like VW Id.4 though |
Contributor
Author
|
Indeed, I missed some test patterns. Fixed it 👨🔧 |
Codecov Report
@@ Coverage Diff @@
## main #380 +/- ##
=========================================
Coverage 93.68% 93.68%
Complexity 1951 1951
=========================================
Files 215 215
Lines 3942 3942
Branches 385 385
=========================================
Hits 3693 3693
Misses 149 149
Partials 100 100 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Thanks Jaap for this pr! Btw, seems our random testing isn't so bad ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current lists of vehicle makes and models did not include many cars that are common in Europe. As discussed in #350.
Extended the lists in
vehicle.ymlbased on some resources on best selling cars in Europe of the past few years.Changed test assertion to accept
CitroënandMercedes-Benzas valid values.