Datafaker wasn't 100% identical when repeating with the same seed, no…

[bodiam]

…w it is. Plus wrote test to prove this, including a test to show that the results are different when it's created with a new faker.

[bodiam]

@jaapcoomans @snuyanzin FYI

[codecov-commenter]

Codecov Report

Merging #384 (d6f3ec4) into main (e61fe88) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #384      +/-   ##
============================================
+ Coverage     93.69%   93.74%   +0.05%     
- Complexity     1951     1953       +2     
============================================
  Files           215      215              
  Lines          3947     3949       +2     
  Branches        385      385              
============================================
+ Hits           3698     3702       +4     
+ Misses          149      148       -1     
+ Partials        100       99       -1     

Impacted Files	Coverage Δ
src/main/java/net/datafaker/base/Password.java	91.52% <ø> (-0.15%)	⬇️
src/main/java/net/datafaker/base/Aws.java	100.00% <100.00%> (ø)
src/main/java/net/datafaker/base/BaseFaker.java	89.87% <100.00%> (+0.12%)	⬆️
src/main/java/net/datafaker/base/Internet.java	90.54% <100.00%> (+0.12%)	⬆️
src/main/java/net/datafaker/movie/StarWars.java	100.00% <0.00%> (+8.33%)	⬆️
...c/main/java/net/datafaker/videogame/Minecraft.java	100.00% <0.00%> (+12.50%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[snuyanzin]

lgtm
I added a couple of commits to make tests green

[bodiam]

@snuyanzin thanks! I missed that the tests were failing, thanks for fixing!