Skip to content

Datafaker wasn't 100% identical when repeating with the same seed, no… - #384

Merged
bodiam merged 3 commits into
mainfrom
repeatability_test
Sep 24, 2022
Merged

Datafaker wasn't 100% identical when repeating with the same seed, no…#384
bodiam merged 3 commits into
mainfrom
repeatability_test

Conversation

@bodiam

@bodiam bodiam commented Sep 24, 2022

Copy link
Copy Markdown
Contributor

…w it is. Plus wrote test to prove this, including a test to show that the results are different when it's created with a new faker.

…w it is. Plus wrote test to prove this, including a test to show that the results are different when it's created with a new faker.
@bodiam

bodiam commented Sep 24, 2022

Copy link
Copy Markdown
Contributor Author

@jaapcoomans @snuyanzin FYI

@bodiam bodiam mentioned this pull request Sep 24, 2022
@codecov-commenter

codecov-commenter commented Sep 24, 2022

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.74%. Comparing base (e61fe88) to head (d6f3ec4).
Report is 1354 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #384      +/-   ##
============================================
+ Coverage     93.69%   93.74%   +0.05%     
- Complexity     1951     1953       +2     
============================================
  Files           215      215              
  Lines          3947     3949       +2     
  Branches        385      385              
============================================
+ Hits           3698     3702       +4     
+ Misses          149      148       -1     
+ Partials        100       99       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@snuyanzin

Copy link
Copy Markdown
Collaborator

lgtm
I added a couple of commits to make tests green

@bodiam
bodiam merged commit f2e0aaf into main Sep 24, 2022
@bodiam

bodiam commented Sep 24, 2022

Copy link
Copy Markdown
Contributor Author

@snuyanzin thanks! I missed that the tests were failing, thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants