Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Bot User Agent #392

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Support Bot User Agent #392

merged 1 commit into from
Sep 25, 2022

Conversation

yuokada
Copy link
Contributor

@yuokada yuokada commented Sep 25, 2022

Support Bot User Agent like faker-ruby/faker#2477 .

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2022

Codecov Report

Merging #392 (7af9e8d) into main (731780d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #392      +/-   ##
============================================
+ Coverage     93.77%   93.80%   +0.02%     
- Complexity     1970     1973       +3     
============================================
  Files           217      217              
  Lines          3968     3987      +19     
  Branches        385      386       +1     
============================================
+ Hits           3721     3740      +19     
  Misses          148      148              
  Partials         99       99              
Impacted Files Coverage Δ
src/main/java/net/datafaker/base/Internet.java 91.61% <100.00%> (+1.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -84,4 +84,32 @@ en:
- Mozilla/5.0 (iPhone; CPU iPhone OS 12_0_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.0 Mobile/15E148 Safari/604.1
- Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/534.59.10 (KHTML, like Gecko) Version/5.1.9 Safari/534.59.10
- Mozilla/5.0 (iPad; CPU OS 9_3_5 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Version/9.0 Mobile/13G36 Safari/601.1

bot_user_agent:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to accept this PR, would you be willing to add more bot names?

@yuokada yuokada marked this pull request as ready for review September 25, 2022 10:21
@bodiam
Copy link
Contributor

bodiam commented Sep 25, 2022

Thanks for this PR, looks fine!

@bodiam bodiam merged commit 27a1e22 into datafaker-net:main Sep 25, 2022
@yuokada yuokada deleted the crawler branch September 26, 2022 00:21
@yuokada
Copy link
Contributor Author

yuokada commented Sep 26, 2022

Thanks for merging. I will send a pull request to enrich bot user agents if I think it's necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants