Skip to content

Support Bot User Agent - #392

Merged
bodiam merged 1 commit into
datafaker-net:mainfrom
yuokada:crawler
Sep 25, 2022
Merged

Support Bot User Agent#392
bodiam merged 1 commit into
datafaker-net:mainfrom
yuokada:crawler

Conversation

@yuokada

@yuokada yuokada commented Sep 25, 2022

Copy link
Copy Markdown
Contributor

Support Bot User Agent like faker-ruby/faker#2477 .

@codecov-commenter

codecov-commenter commented Sep 25, 2022

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.80%. Comparing base (731780d) to head (7af9e8d).
Report is 1347 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #392      +/-   ##
============================================
+ Coverage     93.77%   93.80%   +0.02%     
- Complexity     1970     1973       +3     
============================================
  Files           217      217              
  Lines          3968     3987      +19     
  Branches        385      386       +1     
============================================
+ Hits           3721     3740      +19     
  Misses          148      148              
  Partials         99       99              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/534.59.10 (KHTML, like Gecko) Version/5.1.9 Safari/534.59.10
- Mozilla/5.0 (iPad; CPU OS 9_3_5 like Mac OS X) AppleWebKit/601.1.46 (KHTML, like Gecko) Version/9.0 Mobile/13G36 Safari/601.1

bot_user_agent:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to accept this PR, would you be willing to add more bot names?

@yuokada
yuokada marked this pull request as ready for review September 25, 2022 10:21
@bodiam

bodiam commented Sep 25, 2022

Copy link
Copy Markdown
Contributor

Thanks for this PR, looks fine!

@bodiam
bodiam merged commit 27a1e22 into datafaker-net:main Sep 25, 2022
@yuokada
yuokada deleted the crawler branch September 26, 2022 00:21
@yuokada

yuokada commented Sep 26, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for merging. I will send a pull request to enrich bot user agents if I think it's necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants