Add 'Locality' faker

[panilya]

No description provided.

[codecov-commenter]

Codecov Report

Merging #401 (326a2b0) into main (eecde32) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #401      +/-   ##
============================================
+ Coverage     93.76%   93.81%   +0.05%     
- Complexity     1978     1980       +2     
============================================
  Files           218      218              
  Lines          3994     3995       +1     
  Branches        386      386              
============================================
+ Hits           3745     3748       +3     
- Misses          149      151       +2     
+ Partials        100       96       -4     

Impacted Files	Coverage Δ
...rc/main/java/net/datafaker/base/BaseProviders.java	100.00% <100.00%> (ø)
src/main/java/net/datafaker/base/Locality.java	96.87% <100.00%> (ø)
.../main/java/net/datafaker/service/FakerContext.java	84.61% <0.00%> (-2.57%)	⬇️
...main/java/net/datafaker/service/RandomService.java	94.44% <0.00%> (+2.77%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[panilya]

@snuyanzin Is it okay to do it this way?

[panilya]

I can't find the cause of this test failure

[snuyanzin]

I created a PR to your branch fixing it panilya#2

[bodiam]

There might be a bug here, I'm not 100% sure. The test failed because of the repeatability of the locality:

Expected:

 "locality.displayName"="Russian",
 "locality.localeString"="en-ZA",
 "locality.localeStringWithoutReplacement"="fi-FI",

Actual:

 "locality.displayName"="Armenian",
 "locality.localeString"="vi",
 "locality.localeStringWithoutReplacement"="ru",

Or was this the thing you fixed @snuyanzin , and it just hasn't been merged into the PR yet?

[bodiam]

Ah, it seems all is good now! Thanks both of you!

[panilya]

I think it's ready to merge

[bodiam]

Then let's merge it :-) Nice one, thanks!