Add port provider #409
Merged
Add port provider #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panilya
force-pushed
the
provider/internet-port
branch
from
ececad3 to
7d8cb64
Compare
snuyanzin
reviewed
Sep 28, 2022
snuyanzin
reviewed
Sep 28, 2022
panilya
force-pushed
the
provider/internet-port
branch
4 times, most recently
from
9bb8e5c to
dd6a72b
Compare
snuyanzin
reviewed
Sep 28, 2022
| * @return a port number | ||
| */ | ||
| public int port() { | ||
| return faker.random().nextInt(1, 65535); |
There was a problem hiding this comment.
Based on RFC 6335 https://www.rfc-editor.org/info/rfc6335
allowed range is [0, 65535] so it should be return faker.random().nextInt(0, 65535);
same for test and doc
panilya
force-pushed
the
provider/internet-port
branch
from
dd6a72b to
84b1777
Compare
panilya
force-pushed
the
provider/internet-port
branch
from
84b1777 to
9a6e2ed
Compare
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.