Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented LoremPicsum #410

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Conversation

ChiragMangukia
Copy link
Contributor

@ChiragMangukia ChiragMangukia commented Sep 28, 2022

Issue: #404
Replaced Lorempixel image utility with Lorem Picsum. Removed Lorempixel from the code.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2022

Codecov Report

Merging #410 (aa448c6) into main (cbaaf69) will increase coverage by 0.08%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main     #410      +/-   ##
============================================
+ Coverage     93.80%   93.89%   +0.08%     
- Complexity     1973     1982       +9     
============================================
  Files           217      218       +1     
  Lines          3987     3994       +7     
  Branches        386      384       -2     
============================================
+ Hits           3740     3750      +10     
- Misses          148      150       +2     
+ Partials         99       94       -5     
Impacted Files Coverage Δ
src/main/java/net/datafaker/base/Internet.java 92.12% <66.66%> (+0.50%) ⬆️
.../main/java/net/datafaker/service/FakerContext.java 84.61% <0.00%> (-2.57%) ⬇️
src/main/java/net/datafaker/base/Science.java 100.00% <0.00%> (ø)
.../main/java/net/datafaker/movie/MovieProviders.java 100.00% <0.00%> (ø)
.../java/net/datafaker/base/ProviderRegistration.java 100.00% <0.00%> (ø)
...va/net/datafaker/videogame/VideoGameProviders.java 100.00% <0.00%> (ø)
src/main/java/net/datafaker/movie/MassEffect.java
.../main/java/net/datafaker/service/LocalePicker.java
src/main/java/net/datafaker/base/Overwatch.java
.../main/java/net/datafaker/videogame/MassEffect.java 100.00% <0.00%> (ø)
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam
Copy link
Contributor

bodiam commented Sep 28, 2022

Thank you so much @ChiragMangukia , this is great!

@bodiam bodiam merged commit eef3f61 into datafaker-net:main Sep 28, 2022
@ChiragMangukia ChiragMangukia deleted the lorempicsum branch September 28, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants