-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved Credit card utility #414
Conversation
@Test | ||
void creditCardNumber() { | ||
assertThat(faker.business().creditCardNumber()).isNotEmpty(); | ||
} | ||
@Test | ||
void creditCardNumber() { | ||
assertThat(faker.business().creditCardNumber()).isNotEmpty(); | ||
} | ||
|
||
@Test | ||
void creditCardType() { | ||
assertThat(faker.business().creditCardType()).isNotEmpty(); | ||
} | ||
@Test | ||
void creditCardType() { | ||
assertThat(faker.business().creditCardType()).isNotEmpty(); | ||
} | ||
|
||
@Test | ||
void creditCardExpiry() { | ||
assertThat(faker.business().creditCardExpiry()).isNotEmpty(); | ||
} | ||
@Test | ||
void creditCardExpiry() { | ||
assertThat(faker.business().creditCardExpiry()).isNotEmpty(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have these formatting changes?
Sometimes formatting changes are ok, however I would split logic changes and formatting changes in different commits. It would simplify going through git history while reading the code and trying to understand the logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for heads up! Will take care of it in future PRs :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the change, appreciate it. I'll merge it and reformat it in a new PR, no problem!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tabs to spaces.
Improved Credit card utility request as requested in Issue #411