Improved Credit card utility #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snuyanzin
reviewed
Sep 29, 2022
Comment on lines
-8
to
+21
| @Test | ||
| void creditCardNumber() { | ||
| assertThat(faker.business().creditCardNumber()).isNotEmpty(); | ||
| } | ||
| @Test | ||
| void creditCardNumber() { | ||
| assertThat(faker.business().creditCardNumber()).isNotEmpty(); | ||
| } | ||
|
|
||
| @Test | ||
| void creditCardType() { | ||
| assertThat(faker.business().creditCardType()).isNotEmpty(); | ||
| } | ||
| @Test | ||
| void creditCardType() { | ||
| assertThat(faker.business().creditCardType()).isNotEmpty(); | ||
| } | ||
|
|
||
| @Test | ||
| void creditCardExpiry() { | ||
| assertThat(faker.business().creditCardExpiry()).isNotEmpty(); | ||
| } | ||
| @Test | ||
| void creditCardExpiry() { | ||
| assertThat(faker.business().creditCardExpiry()).isNotEmpty(); | ||
| } |
There was a problem hiding this comment.
Why do we have these formatting changes?
Sometimes formatting changes are ok, however I would split logic changes and formatting changes in different commits. It would simplify going through git history while reading the code and trying to understand the logic
There was a problem hiding this comment.
Thank you for heads up! Will take care of it in future PRs :)
There was a problem hiding this comment.
Thanks for the change, appreciate it. I'll merge it and reformat it in a new PR, no problem!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved Credit card utility request as requested in Issue #411