Added Cricket Provider #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #417 +/- ##
============================================
- Coverage 93.91% 93.87% -0.04%
- Complexity 1985 1990 +5
============================================
Files 218 219 +1
Lines 3996 4003 +7
Branches 384 384
============================================
+ Hits 3753 3758 +5
- Misses 146 147 +1
- Partials 97 98 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
snuyanzin
reviewed
Sep 29, 2022
Co-authored-by: Sergey Nuyanzin <sergey.nuyanzin@aiven.io>
Co-authored-by: Sergey Nuyanzin <sergey.nuyanzin@aiven.io>
Co-authored-by: Sergey Nuyanzin <sergey.nuyanzin@aiven.io>
Co-authored-by: Sergey Nuyanzin <sergey.nuyanzin@aiven.io>
|
Thank You @snuyanzin for the review. I have committed suggested changes. Actually, the reference was taken from FootballTest which has public test methods. |
|
Thanks @ChiragMangukia for this PR, looks great! |
|
@ChiragMangukia thanks for letting us know about the FootballTest. I've made all the test methods a bit more consistent now: #418 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new Cricket Provider.