-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce international and national phone number formats #425
Introduce international and national phone number formats #425
Conversation
Build is falling because it cannot find |
e38aa73
to
45325d1
Compare
@bodiam What if I add |
Shouldn't it fall back to a default format when it can't find it for the current locale? I understand the format will be wrong then, which is fine, we can improve it as we go. |
@bodiam It's a good idea, but tests fall anyway, |
0f4e942
to
34400c5
Compare
34400c5
to
0353945
Compare
0353945
to
ded33ff
Compare
… 'es', 'fr-CA' locales
…NO, no-NO, vi, en'
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
============================================
+ Coverage 92.98% 93.01% +0.02%
- Complexity 2096 2099 +3
============================================
Files 233 233
Lines 4376 4378 +2
Branches 450 450
============================================
+ Hits 4069 4072 +3
- Misses 187 190 +3
+ Partials 120 116 -4 ☔ View full report in Codecov by Sentry. |
Issue: #168
Locales with international and national formats: