Skip to content

Reorder method calls in FakeValuesService#resolveExpression #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

snuyanzin
Copy link
Collaborator

Reorder method calls inside FakeValuesService#resolveExpression to make it more lazy

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2022

Codecov Report

Merging #437 (66bda31) into main (ce20260) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main     #437      +/-   ##
============================================
- Coverage     93.95%   93.93%   -0.03%     
  Complexity     2006     2006              
============================================
  Files           222      222              
  Lines          4023     4021       -2     
  Branches        384      383       -1     
============================================
- Hits           3780     3777       -3     
  Misses          146      146              
- Partials         97       98       +1     
Impacted Files Coverage Δ
.../java/net/datafaker/service/FakeValuesService.java 87.09% <66.66%> (-0.27%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit 66bda31 into datafaker-net:main Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants