Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract retrieveMethodAccessor method, optimize javaNameToYamlName #438

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

snuyanzin
Copy link
Collaborator

The PR extracts common logic into retrieveMethodAccessor
Also it applies some optimizations to javaNameToYamlName

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2022

Codecov Report

Merging #438 (5236d34) into main (66bda31) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #438      +/-   ##
============================================
- Coverage     93.93%   93.92%   -0.01%     
+ Complexity     2006     2002       -4     
============================================
  Files           222      222              
  Lines          4021     4017       -4     
  Branches        383      384       +1     
============================================
- Hits           3777     3773       -4     
- Misses          146      150       +4     
+ Partials         98       94       -4     
Impacted Files Coverage Δ
.../java/net/datafaker/service/FakeValuesService.java 87.20% <100.00%> (+0.10%) ⬆️
.../main/java/net/datafaker/service/FakerContext.java 84.61% <0.00%> (-2.57%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit 5236d34 into datafaker-net:main Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants