Skip to content

Replace isAssignableFrom with == for final classes, refactor retrieveMethodAccessor #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2022

Conversation

snuyanzin
Copy link
Collaborator

For final classes isAssignableFrom could be replaced with == to avoid calling native methods

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022

Codecov Report

Merging #440 (2b5d293) into main (8e86786) will increase coverage by 0.00%.
The diff coverage is 78.94%.

❗ Current head 2b5d293 differs from pull request most recent head 64df541. Consider uploading reports for the commit 64df541 to get more accurate results

@@            Coverage Diff            @@
##               main     #440   +/-   ##
=========================================
  Coverage     93.95%   93.95%           
+ Complexity     2003     2001    -2     
=========================================
  Files           222      222           
  Lines          4017     4019    +2     
  Branches        384      382    -2     
=========================================
+ Hits           3774     3776    +2     
  Misses          146      146           
  Partials         97       97           
Impacted Files Coverage Δ
.../java/net/datafaker/service/FakeValuesService.java 87.25% <78.94%> (+0.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit 64df541 into datafaker-net:main Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants