Replace isAssignableFrom with == for final classes, refactor retrieveMethodAccessor#440
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #440 +/- ##
=========================================
Coverage 93.95% 93.95%
+ Complexity 2003 2001 -2
=========================================
Files 222 222
Lines 4017 4019 +2
Branches 384 382 -2
=========================================
+ Hits 3774 3776 +2
Misses 146 146
Partials 97 97
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For final classes
isAssignableFromcould be replaced with==to avoid calling native methods