-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/pokemon_fr_localization #446
Conversation
Update spotless to 2.27.2
When you cannot install GPG on the machine on which you want to contribute to datafaker, your build fails. By giving some details on how to manage this case in the documentation and by providing a maven profile, it can ease the process for newcomers to the project.
feat/build_without_gpg
synchronization-with-upstream-project
Update of the main branch relatively to the upstream project
Hi @TGITS , tests are always nice, but at the same time I appreciate every contribution and I really don't like to be prescriptive, so if this fixes the issue, all good (I checked, looks good to me) Also thanks for writing an article about this, that's amazing, I'd love to read it when it's done! |
Hi @bodiam, Thanks for your answer. I was a user of JavaFaker and I now use Datafaker since I've discovered it. Thanks for your work and the library. I find it very useful and I gladly recommend it usage around me. |
fix/pokemon_fr_localization (datafaker-net#446)
Thanks for your kind words @TGITS , we're happy you're finding the library useful. If you ever have questions, suggestions, please let us know, and we're happy to help you out! |
(PS: not sure if you're aware, but your fix is already published in the 1.7.0-SNAPSHOT version of Datafaker) |
Working on some code example for a blog post about Datafaker (in French and not yet publisehd), I have noticed the French localization for the pokemon provider does not seem to work properly.
It seems there was a small typo in the
fr.yaml
resource file (and as a matter of fact the same problem in thefr-CA.yaml
file for which I have provided the same fix).I have not found specific unit tests for localization and I have not written some new ones. However I have tested the fixed version against the aformentioned code examples (https://github.com/TGITS/devtoolbox/tree/feat/datafaker/java/library/datafaker/datafaker-example).
Do not hesitate to tell me if you want explicit unit tests to validate the correction.