Rework Generics of Transformer interface - #447
Merged
snuyanzin merged 2 commits intoOct 21, 2022
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
============================================
+ Coverage 93.00% 93.03% +0.02%
- Complexity 2094 2098 +4
============================================
Files 233 233
Lines 4373 4377 +4
Branches 449 449
============================================
+ Hits 4067 4072 +5
+ Misses 190 186 -4
- Partials 116 119 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
awesome, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@snuyanzin could you review generics in Transformer interface, please?
I've found a number of issues here:
Schema<?, ? extends OUT>means thatOUT transform(IN input)function fromFieldinterface could generate the value only of some specific type. For example forCsvTransformerclass,OUTis defined asCharSequence, so it means that we can generate CSV only from CharSequence, we couldn't generate CSV (fields) from other objects (integer, double, boolean e.g.).Take a look on the test case
testCsvWithDifferentObjectsandtestCsvWithDifferentObjectsFunction.INgeneric type should not extends AbstractProvider, because in fact that type corresponds to theSchema<IN, ...>interface then it is passed to the functionOUT transform(IN input)fromFieldinterface, that function takes an argument of IN type and feeds it to the functional interface, which generates the data based on the argument, therefore, the argument could be an object of any type.Take a look on the test case
testCsvWithDifferentObjectsandtestCsvWithDifferentObjectsFunction.Transformershould return a data of typeOUTOtherwise, if we don't want to change the types definition, we have to try to adjust the code to that types.