Rework Generics of Transformer interface #447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@snuyanzin could you review generics in Transformer interface, please?
I've found a number of issues here:
Schema<?, ? extends OUT>
means thatOUT transform(IN input)
function fromField
interface could generate the value only of some specific type. For example forCsvTransformer
class,OUT
is defined asCharSequence
, so it means that we can generate CSV only from CharSequence, we couldn't generate CSV (fields) from other objects (integer, double, boolean e.g.).Take a look on the test case
testCsvWithDifferentObjects
andtestCsvWithDifferentObjectsFunction
.IN
generic type should not extends AbstractProvider, because in fact that type corresponds to theSchema<IN, ...>
interface then it is passed to the functionOUT transform(IN input)
fromField
interface, that function takes an argument of IN type and feeds it to the functional interface, which generates the data based on the argument, therefore, the argument could be an object of any type.Take a look on the test case
testCsvWithDifferentObjects
andtestCsvWithDifferentObjectsFunction
.Transformer
should return a data of typeOUT
Otherwise, if we don't want to change the types definition, we have to try to adjust the code to that types.