Skip to content

Use array and switch for numerify #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snuyanzin merged 1 commit into from
Oct 23, 2022
Merged

Use array and switch for numerify #478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/main/java/net/datafaker/service/FakeValuesService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
import java.util.stream.Collectors;

public class FakeValuesService {
private static final String DIGITS = "0123456789";
private static final char[] DIGITS = "0123456789".toCharArray();
private static final String[] EMPTY_ARRAY = new String[0];
private static final Logger LOG = Logger.getLogger("faker");

Expand Down Expand Up @@ -229,12 +229,16 @@ private String[] split(String string) {
public String numerify(String numberString, FakerContext context) {
char[] res = new char[numberString.length()];
for (int i = 0; i < numberString.length(); i++) {
if (numberString.charAt(i) == '#') {
res[i] = DIGITS.charAt(context.getRandomService().nextInt(10));
} else if (numberString.charAt(i) == 'Ø') {
res[i] = DIGITS.charAt(context.getRandomService().nextInt(1, 9));
} else {
res[i] = numberString.charAt(i);
switch (numberString.charAt(i)) {
case '#':
res[i] = DIGITS[context.getRandomService().nextInt(10)];
break;
case 'Ø':
res[i] = DIGITS[context.getRandomService().nextInt(1, 9)];
break;
default:
res[i] = numberString.charAt(i);
break;
}
}

Expand Down Expand Up @@ -283,7 +287,7 @@ public String examplify(String example, FakerContext context) {
if (Character.isLetter(chars[i])) {
chars[i] = letterify("?", context, Character.isUpperCase(chars[i])).charAt(0);
} else if (Character.isDigit(chars[i])) {
chars[i] = DIGITS.charAt(context.getRandomService().nextInt(10));
chars[i] = DIGITS[context.getRandomService().nextInt(10)];
}
}

Expand Down