Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(small_misprint_in_the_doc) #487

Merged
merged 12 commits into from
Oct 24, 2022

Conversation

TGITS
Copy link
Contributor

@TGITS TGITS commented Oct 24, 2022

Spotted a small error in the doc. Correction proposition.

TGITS added 12 commits October 11, 2022 13:26
Update spotless to 2.27.2
When you cannot install GPG on the machine on which you want to contribute to datafaker, your build fails.
By giving some details on how to manage this case in the documentation and by providing a maven profile, it can ease the process for newcomers to the project.
synchronization-with-upstream-project
Update of the main branch relatively to the upstream project
feat(adding_moves_to_pokemon_provider) (datafaker-net#448)
feat/synchronization_on_upstream
feat/synchronizing_to_upstream_project
Synchronizing with upstream project
Synchronizing with upstream project
Spotted a small error in the doc when reading it.
Suggested fix.
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2022

Codecov Report

Merging #487 (f54a2da) into main (ed7c209) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #487      +/-   ##
============================================
+ Coverage     93.02%   93.05%   +0.03%     
- Complexity     2140     2147       +7     
============================================
  Files           233      234       +1     
  Lines          4473     4481       +8     
  Branches        467      466       -1     
============================================
+ Hits           4161     4170       +9     
+ Misses          196      193       -3     
- Partials        116      118       +2     
Impacted Files Coverage Δ
...net/datafaker/transformations/JsonTransformer.java 84.37% <ø> (ø)
.../net/datafaker/transformations/CsvTransformer.java 96.42% <100.00%> (+3.32%) ⬆️
.../net/datafaker/transformations/SqlTransformer.java 79.56% <100.00%> (-2.61%) ⬇️
...ava/net/datafaker/transformations/Transformer.java 100.00% <100.00%> (ø)
.../main/java/net/datafaker/service/FakerContext.java 87.17% <0.00%> (+2.56%) ⬆️
...java/net/datafaker/transformations/SqlDialect.java 92.30% <0.00%> (+4.61%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit 44d7a0d into datafaker-net:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants