Skip to content

Add support for force usage of sql quote identifiers #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

snuyanzin
Copy link
Collaborator

The usecase is that sometimes column name could be a reserved word and we don't have a chance to know about it without including lots of db specific implementation into this repo e.g. column names like sum, avg, abs and so on

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2022

Codecov Report

Merging #488 (8fb25fd) into main (ed7c209) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #488      +/-   ##
============================================
+ Coverage     93.02%   93.04%   +0.02%     
- Complexity     2140     2147       +7     
============================================
  Files           233      234       +1     
  Lines          4473     4486      +13     
  Branches        467      467              
============================================
+ Hits           4161     4174      +13     
- Misses          196      197       +1     
+ Partials        116      115       -1     
Impacted Files Coverage Δ
...net/datafaker/transformations/JsonTransformer.java 84.37% <ø> (ø)
.../net/datafaker/transformations/CsvTransformer.java 96.42% <100.00%> (+3.32%) ⬆️
.../net/datafaker/transformations/SqlTransformer.java 81.69% <100.00%> (-0.49%) ⬇️
...ava/net/datafaker/transformations/Transformer.java 100.00% <100.00%> (ø)
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 92.59% <0.00%> (-3.71%) ⬇️
...java/net/datafaker/transformations/SqlDialect.java 92.30% <0.00%> (+4.61%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit be15388 into datafaker-net:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants