Skip to content

Multiset could contain duplicates - #493

Merged
snuyanzin merged 1 commit into
datafaker-net:mainfrom
snuyanzin:multiset
Oct 25, 2022
Merged

snuyanzin merged 1 commit into
datafaker-net:mainfrom
snuyanzin:multiset

Conversation

@snuyanzin

Copy link
Copy Markdown
Collaborator

Oopss, forgot that in SQL MULTISET could contain duplicates...
the PR fixes that
now everything that is array goes to sql ARRAY
everything that is java Collection goes to sql MULTISET

@codecov-commenter

codecov-commenter commented Oct 25, 2022

Copy link
Copy Markdown

Codecov Report

Merging #493 (5cab724) into main (0cc948e) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #493      +/-   ##
============================================
+ Coverage     92.96%   93.01%   +0.05%     
+ Complexity     2176     2174       -2     
============================================
  Files           234      234              
  Lines          4603     4595       -8     
  Branches        492      490       -2     
============================================
- Hits           4279     4274       -5     
- Misses          202      203       +1     
+ Partials        122      118       -4     
Impacted Files Coverage Δ
.../net/datafaker/transformations/SqlTransformer.java 84.88% <100.00%> (+1.04%) ⬆️
.../main/java/net/datafaker/service/FakerContext.java 84.61% <0.00%> (-2.57%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin
snuyanzin merged commit 084eb4f into datafaker-net:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants