Skip to content

Multiset could contain duplicates #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2022
Merged

Conversation

snuyanzin
Copy link
Collaborator

Oopss, forgot that in SQL MULTISET could contain duplicates...
the PR fixes that
now everything that is array goes to sql ARRAY
everything that is java Collection goes to sql MULTISET

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Merging #493 (5cab724) into main (0cc948e) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #493      +/-   ##
============================================
+ Coverage     92.96%   93.01%   +0.05%     
+ Complexity     2176     2174       -2     
============================================
  Files           234      234              
  Lines          4603     4595       -8     
  Branches        492      490       -2     
============================================
- Hits           4279     4274       -5     
- Misses          202      203       +1     
+ Partials        122      118       -4     
Impacted Files Coverage Δ
.../net/datafaker/transformations/SqlTransformer.java 84.88% <100.00%> (+1.04%) ⬆️
.../main/java/net/datafaker/service/FakerContext.java 84.61% <0.00%> (-2.57%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit 084eb4f into datafaker-net:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants