Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant bank.yml file #496

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Conversation

panilya
Copy link
Collaborator

@panilya panilya commented Oct 25, 2022

In resources.en there is a file bank.todo.yml. This file basically contains IBAN formats for countries. But, there is already implemented logic for this (in Finance faker), so there is no point to have this file in the project.

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Merging #496 (ab559be) into main (df81dc2) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #496      +/-   ##
============================================
+ Coverage     92.95%   92.99%   +0.04%     
- Complexity     2173     2174       +1     
============================================
  Files           234      234              
  Lines          4596     4596              
  Branches        491      491              
============================================
+ Hits           4272     4274       +2     
+ Misses          204      203       -1     
+ Partials        120      119       -1     
Impacted Files Coverage Δ
.../main/java/net/datafaker/service/files/EnFile.java 93.33% <ø> (ø)
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 96.29% <0.00%> (+3.70%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@epragtbeamtree
Copy link

Makes sense to me to remove it, nice work!

@panilya panilya merged commit 1013e9d into datafaker-net:main Oct 26, 2022
@panilya panilya deleted the remove-bank-file branch October 26, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants