Skip to content

Generate from FakeSequence instead of List + bug fix in sql generator#499

Merged
bodiam merged 3 commits into
datafaker-net:mainfrom
NarekDW:feature/generate-from-fakesequence
Oct 30, 2022
Merged

Generate from FakeSequence instead of List + bug fix in sql generator#499
bodiam merged 3 commits into
datafaker-net:mainfrom
NarekDW:feature/generate-from-fakesequence

Conversation

@NarekDW

@NarekDW NarekDW commented Oct 27, 2022

Copy link
Copy Markdown
Contributor
  1. Changed List<IN> to FakeSequence<IN> in generate function of Transformer interface.
  2. Fix bug in SQL Transformer:
    Example:
BaseFaker faker = new BaseFaker(new Random(10L));
Schema<Integer, ?> schema = Schema.of(
    field("Number", integer -> integer),
    field("Password", integer -> faker.internet().password(integer, integer))
);

SqlTransformer<Integer> transformer = new SqlTransformer.SqlTransformerBuilder<Integer>().build();
// inputs = List or FakeSequence of size 5

String sql = transformer.generate(inputs, schema);

Expected to get 5 (size of inputs) SQL statements, but actual result is 2 (length of schema fields).

@codecov-commenter

codecov-commenter commented Oct 27, 2022

Copy link
Copy Markdown

Codecov Report

Merging #499 (244e54c) into main (14aa886) will increase coverage by 0.29%.
The diff coverage is 80.48%.

@@             Coverage Diff              @@
##               main     #499      +/-   ##
============================================
+ Coverage     93.05%   93.35%   +0.29%     
- Complexity     2188     2202      +14     
============================================
  Files           236      236              
  Lines          4624     4637      +13     
  Branches        491      493       +2     
============================================
+ Hits           4303     4329      +26     
+ Misses          201      185      -16     
- Partials        120      123       +3     
Impacted Files Coverage Δ
...ava/net/datafaker/transformations/Transformer.java 100.00% <ø> (ø)
.../datafaker/transformations/sql/SqlTransformer.java 87.03% <74.07%> (+1.32%) ⬆️
...net/datafaker/transformations/JsonTransformer.java 92.63% <87.50%> (+8.25%) ⬆️
.../net/datafaker/transformations/CsvTransformer.java 96.61% <100.00%> (+0.18%) ⬆️
.../main/java/net/datafaker/service/FakerContext.java 87.17% <0.00%> (+2.56%) ⬆️
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 96.29% <0.00%> (+3.70%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NarekDW

NarekDW commented Oct 27, 2022

Copy link
Copy Markdown
Contributor Author

Is there any windows users? :)
What's wrong with this tests:
net.datafaker.formats.SqlTest.testForceQuotedWithSqlIdentifiers
net.datafaker.formats.SqlTest.testGenerateFromSchemaWithLimitBatchModeStatements
net.datafaker.formats.SqlTest.generateFromFakeSequenceBatch
??

@snuyanzin

Copy link
Copy Markdown
Collaborator

once in a couple of months i'm becoming a windows user =)
i can have a look this weekend

@NarekDW

NarekDW commented Oct 27, 2022

Copy link
Copy Markdown
Contributor Author

I've launched Windows 10 on Virtual Box and all the tests passed there :)

@snuyanzin

Copy link
Copy Markdown
Collaborator

should be fixed in main, however you need to rebase your branch

@NarekDW NarekDW force-pushed the feature/generate-from-fakesequence branch from 77a35ac to 244e54c Compare October 30, 2022 04:44
@NarekDW

NarekDW commented Oct 30, 2022

Copy link
Copy Markdown
Contributor Author

@snuyanzin yep, it works, thank you for the fix!

@bodiam

bodiam commented Oct 30, 2022

Copy link
Copy Markdown
Contributor

Nice, merged!

@bodiam bodiam merged commit 0ed44b8 into datafaker-net:main Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants