Generate from FakeSequence instead of List + bug fix in sql generator#499
Merged
bodiam merged 3 commits intoOct 30, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #499 +/- ##
============================================
+ Coverage 93.05% 93.35% +0.29%
- Complexity 2188 2202 +14
============================================
Files 236 236
Lines 4624 4637 +13
Branches 491 493 +2
============================================
+ Hits 4303 4329 +26
+ Misses 201 185 -16
- Partials 120 123 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
Author
|
Is there any windows users? :) |
Collaborator
|
once in a couple of months i'm becoming a windows user =) |
Contributor
Author
|
I've launched Windows 10 on Virtual Box and all the tests passed there :) |
Collaborator
|
should be fixed in |
77a35ac to
244e54c
Compare
Contributor
Author
|
@snuyanzin yep, it works, thank you for the fix! |
Contributor
|
Nice, merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List<IN>toFakeSequence<IN>in generate function of Transformer interface.Example:
Expected to get 5 (size of inputs) SQL statements, but actual result is 2 (length of schema fields).