Speed up digit generation by using random byte array#508
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #508 +/- ##
============================================
+ Coverage 93.09% 93.32% +0.22%
- Complexity 2184 2216 +32
============================================
Files 235 238 +3
Lines 4618 4656 +38
Branches 491 493 +2
============================================
+ Hits 4299 4345 +46
+ Misses 200 190 -10
- Partials 119 121 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to use generation of random byte array to generate digits.
There is an assumption allowing it to work
number of different digits is less then size of byte range and it is ok (10 vs 256)
So this allows it to speed up for about 30-40%
digitByDigit1 - current approach for 1 digit
digitByDigit10 - current approach for 10 digits
digitByDigit100 - current approach for 100 digits
and etc.