Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests #523

Merged
merged 10 commits into from
Nov 6, 2022
Merged

Add more tests #523

merged 10 commits into from
Nov 6, 2022

Conversation

panilya
Copy link
Collaborator

@panilya panilya commented Nov 3, 2022

No description provided.

@panilya panilya changed the title Add tests for services Add more tests Nov 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #523 (01779ca) into main (25375d0) will increase coverage by 0.32%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #523      +/-   ##
============================================
+ Coverage     92.49%   92.82%   +0.32%     
- Complexity     2295     2353      +58     
============================================
  Files           244      246       +2     
  Lines          4797     4891      +94     
  Branches        507      519      +12     
============================================
+ Hits           4437     4540     +103     
+ Misses          235      227       -8     
+ Partials        125      124       -1     
Impacted Files Coverage Δ
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 92.59% <0.00%> (-3.71%) ⬇️
.../java/net/datafaker/service/FakeValuesService.java 86.23% <0.00%> (-0.65%) ⬇️
src/main/java/net/datafaker/formats/Yaml.java 97.29% <0.00%> (ø)
.../main/java/net/datafaker/service/files/EnFile.java 93.33% <0.00%> (ø)
...main/java/net/datafaker/providers/base/Number.java 100.00% <0.00%> (ø)
...main/java/net/datafaker/transformations/Field.java 100.00% <0.00%> (ø)
...ain/java/net/datafaker/providers/base/Compass.java 100.00% <0.00%> (ø)
...java/net/datafaker/providers/base/PhoneNumber.java 100.00% <0.00%> (ø)
...va/net/datafaker/providers/base/BaseProviders.java 100.00% <0.00%> (ø)
.../main/java/net/datafaker/providers/base/Azure.java 100.00% <0.00%> (ø)
... and 11 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@panilya panilya requested a review from snuyanzin November 4, 2022 13:54
@panilya panilya merged commit 9dc86b1 into datafaker-net:main Nov 6, 2022
@snuyanzin
Copy link
Collaborator

@panilya could you please next time squash your commits before merging to main?
It would simplify searching through git history to understand where(what issue/pr) which change was done

@panilya
Copy link
Collaborator Author

panilya commented Nov 6, 2022

Okay, sorry for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants