Skip to content

Add more tests - #523

Merged
panilya merged 10 commits into
datafaker-net:mainfrom
panilya:fake-values-tests
Nov 6, 2022
Merged

Add more tests#523
panilya merged 10 commits into
datafaker-net:mainfrom
panilya:fake-values-tests

Conversation

@panilya

@panilya panilya commented Nov 3, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

Comment thread src/test/java/net/datafaker/service/FakerIDNTest.java Outdated
Comment thread src/test/java/net/datafaker/service/FakeValuesServiceTest.java Outdated
@panilya panilya changed the title Add tests for services Add more tests Nov 3, 2022
@codecov-commenter

codecov-commenter commented Nov 4, 2022

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (25375d0) to head (01779ca).
Report is 1207 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #523      +/-   ##
============================================
+ Coverage     92.49%   92.90%   +0.41%     
- Complexity     2295     2355      +60     
============================================
  Files           244      246       +2     
  Lines          4797     4891      +94     
  Branches        507      519      +12     
============================================
+ Hits           4437     4544     +107     
+ Misses          235      220      -15     
- Partials        125      127       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panilya
panilya requested a review from snuyanzin November 4, 2022 13:54
Comment thread src/test/java/net/datafaker/FakerTest.java Outdated
Comment thread src/test/java/net/datafaker/formats/SqlTest.java Outdated
@panilya
panilya merged commit 9dc86b1 into datafaker-net:main Nov 6, 2022
@snuyanzin

Copy link
Copy Markdown
Collaborator

@panilya could you please next time squash your commits before merging to main?
It would simplify searching through git history to understand where(what issue/pr) which change was done

@panilya

panilya commented Nov 6, 2022

Copy link
Copy Markdown
Collaborator Author

Okay, sorry for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants