Adds Microsoft Azure provider#524
Merged
bodiam merged 2 commits intodatafaker-net:mainfrom Nov 4, 2022
Merged
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
============================================
+ Coverage 92.49% 92.53% +0.03%
- Complexity 2295 2328 +33
============================================
Files 244 245 +1
Lines 4797 4836 +39
Branches 507 507
============================================
+ Hits 4437 4475 +38
- Misses 235 239 +4
+ Partials 125 122 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Hi @agoncal , great to see you here! Thanks for your contribution! |
bodiam
reviewed
Nov 4, 2022
|
|
||
| /** | ||
| * Generates data for Azure services. This is based on the Azure best practices of naming conventions: | ||
| * <a href="https://learn.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/resource-naming">...</a> |
Contributor
There was a problem hiding this comment.
Small mistake here, I think you used IntelliJ to autofix the urls? (I had a similar issue.)
Contributor
Author
There was a problem hiding this comment.
Yes, Intellij :o) Thanks for fixing it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on some of the most common Azure services naming convention (https://learn.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/resource-abbreviations)