Use getRandomBytes and specific hashcode to speed up text generation#530
Merged
snuyanzin merged 1 commit intodatafaker-net:mainfrom Nov 5, 2022
Merged
Use getRandomBytes and specific hashcode to speed up text generation#530snuyanzin merged 1 commit intodatafaker-net:mainfrom
snuyanzin merged 1 commit intodatafaker-net:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #530 +/- ##
============================================
- Coverage 92.49% 91.93% -0.57%
- Complexity 2349 2360 +11
============================================
Files 246 247 +1
Lines 4891 4947 +56
Branches 519 530 +11
============================================
+ Hits 4524 4548 +24
- Misses 242 268 +26
- Partials 125 131 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By usage of assumption that in case of number of different symbols less than or equals 256 it's possible to use generated byte array and symbols should be unique it could be drastically speed up
before
after
benchmark