Skip to content

Speed up text generation by removal map - #540

Merged
snuyanzin merged 1 commit into
datafaker-net:mainfrom
snuyanzin:text_speed
Nov 7, 2022
Merged

snuyanzin merged 1 commit into
datafaker-net:mainfrom
snuyanzin:text_speed

Conversation

@snuyanzin

Copy link
Copy Markdown
Collaborator

The result of measurement
before


Benchmark           Mode  Cnt     Score     Error   Units
Text.password10   thrpt   10  3324.275 ± 207.978  ops/ms
Text.password100  thrpt   10   953.392 ±   7.367  ops/ms

after

Benchmark           Mode  Cnt     Score     Error   Units
Text.password10   thrpt   10  9167.557 ± 195.276  ops/ms
Text.password100  thrpt   10  1722.053 ±  87.599  ops/ms

@codecov-commenter

codecov-commenter commented Nov 7, 2022

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 69.69697% with 10 lines in your changes missing coverage. Please review.

Project coverage is 92.42%. Comparing base (5f795b8) to head (1ff2d9b).
Report is 1209 commits behind head on main.

Files with missing lines Patch % Lines
...c/main/java/net/datafaker/providers/base/Text.java 69.69% 9 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #540      +/-   ##
============================================
+ Coverage     91.94%   92.42%   +0.47%     
- Complexity     2360     2362       +2     
============================================
  Files           247      247              
  Lines          4953     4936      -17     
  Branches        530      528       -2     
============================================
+ Hits           4554     4562       +8     
+ Misses          268      246      -22     
+ Partials        131      128       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@snuyanzin
snuyanzin merged commit 5fd05ec into datafaker-net:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants