Skip to content

Speed up text generation by removal map #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2022

Conversation

snuyanzin
Copy link
Collaborator

The result of measurement
before


Benchmark           Mode  Cnt     Score     Error   Units
Text.password10   thrpt   10  3324.275 ± 207.978  ops/ms
Text.password100  thrpt   10   953.392 ±   7.367  ops/ms

after

Benchmark           Mode  Cnt     Score     Error   Units
Text.password10   thrpt   10  9167.557 ± 195.276  ops/ms
Text.password100  thrpt   10  1722.053 ±  87.599  ops/ms

@codecov-commenter
Copy link

Codecov Report

Merging #540 (1ff2d9b) into main (5f795b8) will increase coverage by 0.47%.
The diff coverage is 69.69%.

@@             Coverage Diff              @@
##               main     #540      +/-   ##
============================================
+ Coverage     91.94%   92.42%   +0.47%     
- Complexity     2360     2362       +2     
============================================
  Files           247      247              
  Lines          4953     4936      -17     
  Branches        530      528       -2     
============================================
+ Hits           4554     4562       +8     
+ Misses          268      246      -22     
+ Partials        131      128       -3     
Impacted Files Coverage Δ
...c/main/java/net/datafaker/providers/base/Text.java 78.81% <69.69%> (+9.18%) ⬆️
...ain/java/net/datafaker/idnumbers/EnZAIdNumber.java 83.33% <0.00%> (-8.34%) ⬇️
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 92.59% <0.00%> (-3.71%) ⬇️
.../java/net/datafaker/service/FakeValuesService.java 86.02% <0.00%> (-0.87%) ⬇️
...rc/main/java/net/datafaker/service/FakeValues.java 82.97% <0.00%> (+1.06%) ⬆️
.../datafaker/transformations/sql/SqlTransformer.java 88.14% <0.00%> (+1.11%) ⬆️
...java/net/datafaker/providers/base/DateAndTime.java 98.52% <0.00%> (+1.47%) ⬆️
.../main/java/net/datafaker/service/FakerContext.java 89.74% <0.00%> (+2.56%) ⬆️
...n/java/net/datafaker/providers/base/BaseFaker.java 93.90% <0.00%> (+4.87%) ⬆️
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit 5fd05ec into datafaker-net:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants