Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use already found dot index #546

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Use already found dot index #546

merged 1 commit into from
Nov 10, 2022

Conversation

snuyanzin
Copy link
Collaborator

Also a bit speed up which gives about 10%
before

Benchmark                                      Mode  Cnt     Score     Error   Units
DatafakerExpressions.numberbetweenExpression  thrpt   10  3333.331 ± 246.507  ops/ms

after

Benchmark                                      Mode  Cnt     Score    Error   Units
DatafakerExpressions.numberbetweenExpression  thrpt   10  3666.636 ± 26.251  ops/ms

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Merging #546 (749a585) into main (a5eaa17) will increase coverage by 0.01%.
The diff coverage is 70.00%.

@@             Coverage Diff              @@
##               main     #546      +/-   ##
============================================
+ Coverage     92.65%   92.67%   +0.01%     
+ Complexity     2370     2369       -1     
============================================
  Files           247      247              
  Lines          4945     4944       -1     
  Branches        531      530       -1     
============================================
  Hits           4582     4582              
+ Misses          238      237       -1     
  Partials        125      125              
Impacted Files Coverage Δ
.../java/net/datafaker/service/FakeValuesService.java 87.31% <70.00%> (-0.03%) ⬇️
...c/main/java/net/datafaker/providers/base/Text.java 78.81% <0.00%> (+0.84%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit 062c0e1 into datafaker-net:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants