-
Notifications
You must be signed in to change notification settings - Fork 228
Support transformation schema for XML #549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/documentation/schema.md
Outdated
| worknumbers: [(715) 228-3360 x9556, (936) 907-6813 x7053] | ||
| cellphones: [410.609.5559, 1-720-415-7634, 786-631-7588] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm...
that's not good it should generate
like
name: Katharyn
lastname: Predovic
phones:
worknumbers:
- (715) 228-3360 x9556
- (936) 907-6813 x7053
cellphones:
- 410.609.5559
- 1-720-415-7634
- 786-631-7588There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you are right.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
============================================
- Coverage 92.66% 92.61% -0.05%
- Complexity 2374 2405 +31
============================================
Files 248 249 +1
Lines 4951 5040 +89
Branches 530 543 +13
============================================
+ Hits 4588 4668 +80
- Misses 241 246 +5
- Partials 122 126 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@snuyanzin can this be merged? |
| Field<IN, ?> content = Arrays.stream(attrs) | ||
| .filter(inField -> !isAttribute(inField.getName())).findFirst() | ||
| .orElse(null); | ||
| applyTag(input, sb, content, tag); | ||
| } else { | ||
| applyTag(input, sb, xmlNode, tag); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could a bit simpler like
| Field<IN, ?> content = Arrays.stream(attrs) | |
| .filter(inField -> !isAttribute(inField.getName())).findFirst() | |
| .orElse(null); | |
| applyTag(input, sb, content, tag); | |
| } else { | |
| applyTag(input, sb, xmlNode, tag); | |
| } | |
| xmlNode = Arrays.stream(attrs) | |
| .filter(inField -> !isAttribute(inField.getName())).findFirst() | |
| .orElse(null); | |
| } | |
| applyTag(input, sb, xmlNode, tag); |
|
in general lgtm |
|
Thanks for this change! Time to release I think!! |
The PR introduces XML transformer.
An example of usage
Result: