Skip to content

Add Marvel Snap Provider - #557

Merged
bodiam merged 6 commits into
datafaker-net:mainfrom
isvora:isvora/marvel_snap
Nov 29, 2022
Merged

Add Marvel Snap Provider#557
bodiam merged 6 commits into
datafaker-net:mainfrom
isvora:isvora/marvel_snap

Conversation

@isvora

@isvora isvora commented Nov 24, 2022

Copy link
Copy Markdown
Contributor

Added provider for the new trading card game called Marvel Snap

Comment thread src/main/java/net/datafaker/service/files/EnFile.java Outdated
Comment thread README.md Outdated
Comment thread src/main/java/net/datafaker/providers/videogame/MarvelSnap.java Outdated
Comment thread src/main/java/net/datafaker/providers/videogame/MarvelSnap.java Outdated
@bodiam

bodiam commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

Nice, thanks! Could you also please make the other methods singular? Thanks!

Comment thread src/main/java/net/datafaker/service/files/EnFile.java Outdated
Comment thread src/test/java/net/datafaker/providers/videogame/MarvelSnapTest.java Outdated
@isvora
isvora requested a review from bodiam November 29, 2022 19:35
@bodiam
bodiam merged commit 4e2f58a into datafaker-net:main Nov 29, 2022
@bodiam

bodiam commented Nov 29, 2022

Copy link
Copy Markdown
Contributor

Thanks @isvora , looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants