Skip to content

Documentation update: rename IProviders to BaseProviders #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

danilopiazza
Copy link
Contributor

IProviders has been renamed to BaseProviders in #376. This pull request updates the code samples in custom-providers.md.

@snuyanzin
Copy link
Collaborator

snuyanzin commented Nov 30, 2022

What is the reason of such rename?
BaseProviders implies some base providers stuff...
IProviders what does it imply?

Ok, it's about documentation samples, now got it

@bodiam
Copy link
Contributor

bodiam commented Nov 30, 2022

Thanks @danilopiazza for spotting this, and thanks for the fix!

@bodiam bodiam merged commit 2c96eb5 into datafaker-net:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants