Skip to content

Add Korean resident registration number #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Conversation

NULL0xFF
Copy link
Contributor

@NULL0xFF NULL0xFF commented Dec 7, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2022

Codecov Report

Merging #569 (8b6d010) into main (2c96eb5) will decrease coverage by 0.03%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##               main     #569      +/-   ##
============================================
- Coverage     92.57%   92.53%   -0.04%     
- Complexity     2417     2425       +8     
============================================
  Files           251      252       +1     
  Lines          5062     5080      +18     
  Branches        546      551       +5     
============================================
+ Hits           4686     4701      +15     
- Misses          248      250       +2     
- Partials        128      129       +1     
Impacted Files Coverage Δ
...ain/java/net/datafaker/idnumbers/KoKrIdNumber.java 87.50% <87.50%> (ø)
...in/java/net/datafaker/providers/base/IdNumber.java 100.00% <100.00%> (ø)
...c/main/java/net/datafaker/providers/base/Text.java 77.96% <0.00%> (-0.85%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam
Copy link
Contributor

bodiam commented Dec 7, 2022

Looks fine to me! Thanks for this PR!

@bodiam bodiam merged commit f1b90d4 into datafaker-net:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants