Skip to content

Make call to FakeValues#loadValues once#575

Merged
bodiam merged 1 commit into
datafaker-net:mainfrom
snuyanzin:574
Dec 21, 2022
Merged

Make call to FakeValues#loadValues once#575
bodiam merged 1 commit into
datafaker-net:mainfrom
snuyanzin:574

Conversation

@snuyanzin

Copy link
Copy Markdown
Collaborator

Probably a solution for #574

@codecov-commenter

codecov-commenter commented Dec 21, 2022

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.43%. Comparing base (d4c21e1) to head (13ce1f2).
Report is 1153 commits behind head on main.

Files with missing lines Patch % Lines
...rc/main/java/net/datafaker/service/FakeValues.java 77.77% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #575      +/-   ##
============================================
- Coverage     92.56%   92.43%   -0.13%     
+ Complexity     2427     2424       -3     
============================================
  Files           252      252              
  Lines          5082     5089       +7     
  Branches        551      553       +2     
============================================
  Hits           4704     4704              
- Misses          249      251       +2     
- Partials        129      134       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bodiam bodiam merged commit 5ebd43d into datafaker-net:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants