Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make call to FakeValues#loadValues once #575

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Conversation

snuyanzin
Copy link
Collaborator

Probably a solution for #574

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2022

Codecov Report

Merging #575 (13ce1f2) into main (d4c21e1) will decrease coverage by 0.12%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##               main     #575      +/-   ##
============================================
- Coverage     92.56%   92.43%   -0.13%     
+ Complexity     2427     2424       -3     
============================================
  Files           252      252              
  Lines          5082     5089       +7     
  Branches        551      553       +2     
============================================
  Hits           4704     4704              
- Misses          249      251       +2     
- Partials        129      134       +5     
Impacted Files Coverage Δ
...rc/main/java/net/datafaker/service/FakeValues.java 82.17% <77.77%> (-0.81%) ⬇️
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 92.59% <0.00%> (-3.71%) ⬇️
.../java/net/datafaker/service/FakeValuesService.java 86.07% <0.00%> (-0.63%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam bodiam merged commit 5ebd43d into datafaker-net:main Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants