Skip to content

Speed up FakeValues#toJavaNames - #579

Merged
snuyanzin merged 1 commit into
datafaker-net:mainfrom
snuyanzin:toJavaName
Dec 23, 2022
Merged

Speed up FakeValues#toJavaNames#579
snuyanzin merged 1 commit into
datafaker-net:mainfrom
snuyanzin:toJavaName

Conversation

@snuyanzin

Copy link
Copy Markdown
Collaborator

Usage of array instead of StringBuilder speeds up more than 2 times
before

Benchmark                Mode  Cnt      Score     Error   Units
ToJavaName.toJavaName2  thrpt   10  21737.634 ± 552.641  ops/ms

after

Benchmark                Mode  Cnt      Score     Error   Units
ToJavaName.toJavaName   thrpt   10  57957.671 ± 783.179  ops/ms

@codecov-commenter

codecov-commenter commented Dec 23, 2022

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.48%. Comparing base (6930ebe) to head (1f648b2).
Report is 1152 commits behind head on main.

Files with missing lines Patch % Lines
...rc/main/java/net/datafaker/service/FakeValues.java 82.35% 0 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #579      +/-   ##
============================================
+ Coverage     92.43%   92.48%   +0.05%     
- Complexity     2427     2431       +4     
============================================
  Files           252      252              
  Lines          5090     5099       +9     
  Branches        556      560       +4     
============================================
+ Hits           4705     4716      +11     
+ Misses          250      249       -1     
+ Partials        135      134       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@snuyanzin
snuyanzin merged commit 2e96510 into datafaker-net:main Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants