Skip to content

Return supported locales #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 4, 2023
Merged

Return supported locales #589

merged 4 commits into from
Jan 4, 2023

Conversation

snuyanzin
Copy link
Collaborator

Descrease number of exceptions in case of empty filename
Make it returning supported locales both for jars and source
Also there is support for custom locales added via custom providers
e.g.

faker.locality().allSupportedLocales(Set.of("datafaker", "custom jar"));

in args need to pass jar names to look at

should fix #566

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #589 (5a6c12c) into main (8ce9e40) will decrease coverage by 0.30%.
The diff coverage is 45.71%.

@@             Coverage Diff              @@
##               main     #589      +/-   ##
============================================
- Coverage     93.50%   93.20%   -0.31%     
- Complexity     2441     2442       +1     
============================================
  Files           252      252              
  Lines          5053     5075      +22     
  Branches        551      558       +7     
============================================
+ Hits           4725     4730       +5     
- Misses          193      208      +15     
- Partials        135      137       +2     
Impacted Files Coverage Δ
...n/java/net/datafaker/providers/base/BaseFaker.java 94.04% <ø> (ø)
...in/java/net/datafaker/providers/base/Locality.java 64.81% <45.71%> (-32.07%) ⬇️
...rc/main/java/net/datafaker/service/FakeValues.java 82.14% <0.00%> (-0.90%) ⬇️
.../datafaker/transformations/sql/SqlTransformer.java 88.19% <0.00%> (+0.73%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin
Copy link
Collaborator Author

probably need to debug a bit windows version

@snuyanzin snuyanzin merged commit c2010ee into datafaker-net:main Jan 4, 2023
snuyanzin added a commit to snuyanzin/datafaker that referenced this pull request Jan 4, 2023
* Return supported locales

* Use File.pathSeparator

* Extract visitor

* Extract visitor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List available locales we can use with DataFaker
2 participants