Return supported locales - #589
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #589 +/- ##
============================================
- Coverage 93.50% 93.20% -0.31%
- Complexity 2441 2442 +1
============================================
Files 252 252
Lines 5053 5075 +22
Branches 551 558 +7
============================================
+ Hits 4725 4730 +5
- Misses 193 208 +15
- Partials 135 137 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
Author
|
probably need to debug a bit windows version |
snuyanzin
added a commit
to snuyanzin/datafaker
that referenced
this pull request
Jan 4, 2023
* Return supported locales * Use File.pathSeparator * Extract visitor * Extract visitor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrease number of exceptions in case of empty filename
Make it returning supported locales both for jars and source
Also there is support for custom locales added via custom providers
e.g.
in args need to pass jar names to look at
should fix #566