Skip to content

Log error instead of throwing and catching #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

snuyanzin
Copy link
Collaborator

There is a useless throwing of exception in case there is no any method found and then just log it...
Instead it should be just logged without throwing

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023

Codecov Report

Merging #594 (3aaaba1) into main (c2010ee) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #594      +/-   ##
============================================
- Coverage     93.13%   93.11%   -0.02%     
- Complexity     2441     2443       +2     
============================================
  Files           252      252              
  Lines          5095     5097       +2     
  Branches        561      562       +1     
============================================
+ Hits           4745     4746       +1     
- Misses          209      211       +2     
+ Partials        141      140       -1     
Impacted Files Coverage Δ
.../java/net/datafaker/service/FakeValuesService.java 85.74% <100.00%> (-0.56%) ⬇️
.../datafaker/transformations/sql/SqlTransformer.java 88.19% <0.00%> (+0.73%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@snuyanzin snuyanzin merged commit 87471f0 into datafaker-net:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants