Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#635 - Expand SV local names #638

Merged

Conversation

robosoul
Copy link
Contributor

Added sv locale firs/last names based on lists from wiki:

Previous # of elements:

% grep 'female_first_name' sv.yml | grep -o '[[][^]]*]' | sed 's/[[]//; s/[]]//; s/, /,/g' | tr ',' '\n' | wc -l
      13

% grep '[^a-z]male_first_name' sv.yml | grep -o '[[][^]]*]' | sed 's/[[]//; s/[]]//; s/, /,/g' | tr ',' '\n' | wc -l
      14

% grep 'last_name' sv.yml | grep -o '[[][^]]*]' | sed 's/[[]//; s/[]]//; s/, /,/g' | tr ',' '\n' | wc -l
      13

New # of elements:

 % grep 'female_first_name' src/main/resources/sv.yml | grep -o '[[][^]]*]' | sed 's/[[]//; s/[]]//; s/, /,/g' | tr ',' '\n' | wc -l
     177

% grep '[^a-z]male_first_name' src/main/resources/sv.yml | grep -o '[[][^]]*]' | sed 's/[[]//; s/[]]//; s/, /,/g' | tr ',' '\n' | wc -l
     200

% grep 'last_name' src/main/resources/sv.yml | grep -o '[[][^]]*]' | sed 's/[[]//; s/[]]//; s/, /,/g' | tr ',' '\n' | wc -l
     697

@what-the-diff
Copy link

what-the-diff bot commented Jan 19, 2023

  • Added female first names
  • Added male first names
  • Changed last name to plural form (last_name -> last_names) and added more surnames

@robosoul robosoul mentioned this pull request Jan 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Merging #638 (2dede3d) into main (53e14a4) will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #638      +/-   ##
============================================
+ Coverage     92.69%   92.75%   +0.05%     
- Complexity     2620     2621       +1     
============================================
  Files           281      281              
  Lines          5396     5396              
  Branches        589      589              
============================================
+ Hits           5002     5005       +3     
+ Misses          241      239       -2     
+ Partials        153      152       -1     
Impacted Files Coverage Δ
...ain/java/net/datafaker/idnumbers/KoKrIdNumber.java 81.25% <0.00%> (-6.25%) ⬇️
.../datafaker/transformations/sql/SqlTransformer.java 87.45% <0.00%> (-0.74%) ⬇️
.../java/net/datafaker/service/FakeValuesService.java 84.95% <0.00%> (+0.19%) ⬆️
...ker/idnumbers/pt/br/IdNumberGeneratorPtBrUtil.java 96.29% <0.00%> (+3.70%) ⬆️
.../main/java/net/datafaker/service/FakerContext.java 88.05% <0.00%> (+4.47%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bodiam
Copy link
Contributor

bodiam commented Jan 19, 2023

Looks fine to me! Thanks for this!!

@bodiam bodiam merged commit db7436d into datafaker-net:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants