Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#636 - Expand NO local names #639

Merged

Conversation

robosoul
Copy link
Contributor

@what-the-diff
Copy link

what-the-diff bot commented Jan 19, 2023

  • Added female_first_name, male_first_name and first name
  • Added last names
  • added prefixes to the name generator
  • changed some of the weights for generating a full name with middle initial (last two lines)

@robosoul
Copy link
Contributor Author

20 names before the change:

Mrs. Stanton Senger
Miss Alva Emmerich
Albert Braun V
Raul Zulauf III
Tanisha Lowe
Hubert Ortiz
Ms. Pierre Kulas
Charlie Borer
Brande Schoen
Milo Fahey
Grady Pacocha
Efren Cronin
Francisco Sauer
Mrs. Cristobal Fisher
Lang Rohan I
Bradford Gleichner
Dr. Emilio Schaden
Luis Ernser
Miss Kirstin Nitzsche

20 names after the change:


Nils Næsheim
Petter Hjelde
Irnes Karlsen
Fru Arthur Haalke
Heine Solås
Ditlef Irvoll
Monika Bjørgen
Leidulv Gaarder
Kari Rask
Haldor Palmstrøm
Hr. Jonas Kvarme
Grete Stordalen
Sigrid Hovind
Tove Kvalø
Odin Bjørgaas
Iselin Gjertsen
Jørgen Bjerke
Hr. Siri Schulerud
Dagny Kapstad

@robosoul
Copy link
Contributor Author

Some counts:

 % grep 'female_first_name' src/main/resources/no-NO.yml | grep -o '[[][^]]*]' | sed 's/[[]//; s/[]]//; s/, /,/g' | tr ',' '\n' | wc -l
     145

 % grep '[^a-z]male_first_name' src/main/resources/no-NO.yml | grep -o '[[][^]]*]' | sed 's/[[]//; s/[]]//; s/, /,/g' | tr ',' '\n' | wc -l
     200

% grep 'last_name' src/main/resources/no-NO.yml | grep -o '[[][^]]*]' | sed 's/[[]//; s/[]]//; s/, /,/g' | tr ',' '\n' | wc -l
     827

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Merging #639 (7b5fa5c) into main (53e14a4) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #639      +/-   ##
============================================
+ Coverage     92.69%   92.71%   +0.01%     
- Complexity     2620     2622       +2     
============================================
  Files           281      281              
  Lines          5396     5396              
  Branches        589      589              
============================================
+ Hits           5002     5003       +1     
- Misses          241      242       +1     
+ Partials        153      151       -2     
Impacted Files Coverage Δ
...c/main/java/net/datafaker/providers/base/Text.java 77.96% <0.00%> (-0.85%) ⬇️
.../java/net/datafaker/service/FakeValuesService.java 84.95% <0.00%> (+0.19%) ⬆️
...rc/main/java/net/datafaker/service/FakeValues.java 84.16% <0.00%> (+0.83%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@robosoul robosoul mentioned this pull request Jan 19, 2023
@bodiam
Copy link
Contributor

bodiam commented Jan 19, 2023

Much better indeed! Nice!

@bodiam bodiam merged commit 6d49cef into datafaker-net:main Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants